docs: update to square size 128 #1880
Conversation
|
Warning Rate limit exceeded@jcstein has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 26 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe pull request updates the Celestia mainnet documentation to reflect an increase in the maximum square size from 64 to 128. This change impacts the total blob size allowed in transactions, expanding it from approximately 2 MiB to 8 MiB. The documentation specifically updates the numerical values related to network parameters, including the number of shares and total bytes calculation, while maintaining the overall document structure. Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Co-authored-by: Rootul P <[email protected]>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
how-to-guides/mainnet.md(1 hunks)
🔇 Additional comments (2)
how-to-guides/mainnet.md (2)
60-61: LGTM!The calculations for total shares (128×128 = 16384) and remaining shares (16384 - 1 = 16383) are mathematically correct.
69-69: LGTM!The total bytes calculation is mathematically correct:
- First share: 1 × 478 = 478 bytes
- Remaining shares: 16382 × 482 = 7,896,124 bytes
- Total: 478 + 7,896,124 = 7,896,602 bytes
how-to-guides/mainnet.md
Outdated
| governance maximum square size is 128, the total blob size in a transaction | ||
| must be slightly less than ~8 MiB, or 7,895,546 bytes to be exact. |
There was a problem hiding this comment.
Verify the exact byte count.
The stated exact byte count (7,895,546) differs from the calculation result in line 69 (7,896,602). This inconsistency should be resolved.
Apply this diff to fix the inconsistency:
-must be slightly less than ~8 MiB, or 7,895,546 bytes to be exact.
+must be slightly less than ~8 MiB, or 7,896,602 bytes to be exact.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| governance maximum square size is 128, the total blob size in a transaction | |
| must be slightly less than ~8 MiB, or 7,895,546 bytes to be exact. | |
| governance maximum square size is 128, the total blob size in a transaction | |
| must be slightly less than ~8 MiB, or 7,896,602 bytes to be exact. |
Overview
Resolves #1879
Summary by CodeRabbit